search

lovelysystems / lovely.buildouthttp

zc.buildout extension to add http authentication for find-links and download recipies
Other
4 stars 9 forks source link

New feature and some cleanup #1

Closed claytron closed 13 years ago

claytron commented 13 years ago

I implemented a new feature where you can add a .httpauth to the current buildout directory in addition to the ~/.buildout/.httpauth. If the two are available, the contents of both are combined and later evaluated.

While I was in the neighborhood, I fixed up the README so it was clearer and ran PEP8 on the code. I realize now that I was a bit over zealous with the README and CHANGES header level changes. I can remove that particular change if you'd like.

dobe commented 13 years ago

hi

thx for the addition, would you mind documenting this in the install.txt test? The reason why the ~/.buildout/.httpauth case is not tested is because we cannot write to the users home dir in the test, but your addition can be tested.

i did not test it, but i think that os.getcwd() is the wrong way to get the buildout root, you should use buildout['directory'] instead.

we always use the same header levels in all our projects. these are also used on pypi so i would like to keep them as they are along with the changelog formatting, therefore it would be nice to remove 4791e0b

regards, bernd

claytron commented 13 years ago

I'll fix up these items and re-submit a pull request.