search

lovelysystems / lovely.buildouthttp

zc.buildout extension to add http authentication for find-links and download recipies
Other
4 stars 9 forks source link

Add user agent for github #13

Closed 1stvamp closed 11 years ago

1stvamp commented 11 years ago

The GitHub API now requires the useragent to always be set, and as lovely.buildouthttp creates a new request when it adds auth details we lose that header, this patch adds it back in from the old request object.

See for more info on the API change: http://developer.github.com/changes/2013-04-24-user-agent-required/

jodok commented 11 years ago

sorry 1stvamp, we just noticed that we were not informed about open pull requests on our public repositories. we'll work on them asap!

1stvamp commented 11 years ago

No problem I've had exactly the same issue with PRs for my own projects several times. :smile:

On Tuesday, 18 June 2013, Jodok Batlogg wrote:

sorry 1stvamp, we just noticed that we were not informed about open pull requests on our public repositories. we'll work on them asap!

— Reply to this email directly or view it on GitHubhttps://github.com/lovelysystems/lovely.buildouthttp/pull/13#issuecomment-19634489 .

Wes

http://1stvamp.org/ http://wesleymason.name/

mfussenegger commented 11 years ago

Hi @1stvamp

thanks for you contribution. I've just merged it and made a new release to pypi.

1stvamp commented 11 years ago

Yay! Thank you. :smile: On 25 Jun 2013 21:31, "Mathias Fußenegger" notifications@github.com wrote:

Hi @1stvamp https://github.com/1stvamp

thanks for you contribution. I've just merged it and made a new release to pypi.

— Reply to this email directly or view it on GitHubhttps://github.com/lovelysystems/lovely.buildouthttp/pull/13#issuecomment-20004738 .