lovelysystems / lovely.buildouthttp

zc.buildout extension to add http authentication for find-links and download recipies
Other
4 stars 9 forks source link

Empty lines cause error reading .httpauth file #3

Closed claytron closed 13 years ago

claytron commented 13 years ago

If I have an .httpauth file with some trailing blank lines like this:

my-project,https://dist.example.com/private/my-project,username,password
<BLANKLINE>
<BLANKLINE>

Then I get this error:

lovely.buildouthttp: Added credentials 'my-project', 'https://dist.example.com/private/my-project'
While:
  Installing.
  Loading extensions.

An internal error occured due to a bug in either zc.buildout or in a
recipe being used:
Traceback (most recent call last):
  File "/usr/home/username/.buildout/eggs/zc.buildout-1.4.3-py2.6.egg/zc/buildout/buildout.py", line 1660, in main
    getattr(buildout, command)(args)
  File "/usr/home/username/.buildout/eggs/zc.buildout-1.4.3-py2.6.egg/zc/buildout/buildout.py", line 373, in install
    self._load_extensions()
  File "/usr/home/username/.buildout/eggs/zc.buildout-1.4.3-py2.6.egg/zc/buildout/buildout.py", line 894, in _load_extensions
    ep.load()(self)
  File "/usr/home/username/.buildout/eggs/lovely.buildouthttp-0.4.0-py2.6.egg/lovely/buildouthttp/buildouthttp.py", line 163, in install
    pwd_path, l + 1))
RuntimeError: Authentication file cannot be parsed None:2

Seems like the extension should just ignore any blank lines in the .httpauth file.

jukart commented 13 years ago

Fixed in version 0.4.1.