loverajoel / jstips

This is about useful JS tips!
http://jstips.co
GNU General Public License v3.0
12.5k stars 803 forks source link

Tip #48 has confusing title #302

Closed gromgit closed 8 years ago

gromgit commented 8 years ago

I interpret Reduce builtin function usage as "cut down on your usage of native functions", which is a downright bizarre sentiment.

@darul75 I suggest a catchier and more accurate replacement: How to reduce() and PROFIT!

loverajoel commented 8 years ago

@darul75 what do you think about it?

kurtextrem commented 8 years ago

I think your proposed title is a bit too catchy, but I can definitely see why we should rename it. Quick fix: adding backticks?

gromgit commented 8 years ago

Or perhaps a simple How to reduce() arrays?

zenopopovici commented 8 years ago

@gromgit PR please.

darul75 commented 8 years ago

Hi all,

Sure it was a bit confusing and I did not know how to express it well.

I have to think about it too but if you have idea just put it I am on holiday now and connexion very bad here.

Kindly,

Julien

Port: 06 24 79 14 83

2016-03-02 0:22 GMT+01:00 Zeno Popovici notifications@github.com:

@gromgit https://github.com/gromgit PR please.

— Reply to this email directly or view it on GitHub https://github.com/loverajoel/jstips/issues/302#issuecomment-190959235.

gromgit commented 8 years ago

@zenopopovici Done, #308

kurtextrem commented 8 years ago

If @darul75 is fine with that :shipit: (#308)

2016-03-02 6:28 GMT+01:00 gromgit notifications@github.com:

@zenopopovici https://github.com/zenopopovici Done, #308 https://github.com/loverajoel/jstips/pull/308

— Reply to this email directly or view it on GitHub https://github.com/loverajoel/jstips/issues/302#issuecomment-191068749.

darul75 commented 8 years ago

Sounds good :+1:

loverajoel commented 8 years ago

merged!

Thanks all :+1: