loverajoel / jstips

This is about useful JS tips!

http://jstips.co

GNU General Public License v3.0

12.5k stars 803 forks source link

page build problem #312

Closed neighborhood999 closed 8 years ago

neighborhood999 commented 8 years ago

295

if tip-tldr start with (`), make build failure.

after fix:

so we need add this information to CONTRIBUTING for user.

zenopopovici commented 8 years ago

@neighborhood999 https://github.com/loverajoel/jstips/blob/gh-pages/CONTRIBUTING.md It's already added... We as contributors must be vigilant before performing merges also.

loverajoel commented 8 years ago

for some reason, the build is broken and don't are sending the alert email. I merged a new tip and sent another fix and the page didn't rebuild. Any ideas?

loverajoel commented 8 years ago

In local everything works as expected

loverajoel commented 8 years ago

done :p

zenopopovici commented 8 years ago

What was the issue?

neighborhood999 commented 8 years ago

@zenopopovici I megred before I have check, but I don't know tip-tldr let page build broken...

yesterday, I wording contributors_zh_TW but in Use backticks.. display is not normal... I have fix and send PR #315 I know I am collaborator but I think this need @loverajoel @zenopopovici review and check, thanks :smile:

zenopopovici commented 8 years ago

@neighborhood999 Thanks ... I merged the change ... it looked fine in code, I'll be more careful.

Also please feel free to fix things if you see a problem. I think it's better for a problem to be fixes as soon as possible than to wait for someone to approve an obvious fix.

We can easily revert stuff if we do mistakes.

loverajoel commented 8 years ago

I think that my problem was Github lag, now everything are working as expected!