search

loverajoel / jstips

This is about useful JS tips!
http://jstips.co
GNU General Public License v3.0
12.5k stars 803 forks source link

Measure Operation time using `console` object #323

Closed SarjuHansaliya closed 8 years ago

SarjuHansaliya commented 8 years ago

Measure Operation time using console object

TL;DR;

Measure Operation time using console object

Username

SarjuHansaliya

SarjuHansaliya commented 8 years ago

@kurtextrem Thanks. Is it good now?

SarjuHansaliya commented 8 years ago

@kurtextrem thanks :+1:

loverajoel commented 8 years ago

@SarjuHansaliya There is one tip equal than yours, take a look here. What about merge both?

SarjuHansaliya commented 8 years ago

Ohh Sure , We should merge both. Sorry I haven't seen that post earlier

zenopopovici commented 8 years ago

@SarjuHansaliya Just make changes on that one and submit a new PR.

SarjuHansaliya commented 8 years ago

Can you help me ? I don't see any "Create Pull Request" Button. screen shot 2016-03-12 at 10 06 35 am

Do I have to close this PR ?

gromgit commented 8 years ago

@SarjuHansaliya I suggest you leave this PR alone for now, just start a new one on the other tip. Then when you're done submitting that PR, come back here and close this one.

SarjuHansaliya commented 8 years ago

@gromgit I am new to git , so I am little bit confused. I have made changes to tip 13 in my local , then I push it to my forked repo on github. Now those commits are listed here , why so ?

Even I can't see new PR button ?

Can you guide me?

gromgit commented 8 years ago

@SarjuHansaliya Ah, I didn't notice the problem earlier. GitHub tracks PR content by branch; since all your changes were on the main gh-pages branch, what you ended up doing was combine all your changes (even for other tips) into this PR instead.

The cleanest and most reliable way to resolve this is to close this PR and reset your own state:

  1. Copy out any changed files from your old fork to another directory.
  2. Delete your old fork on GitHub.
  3. Delete the local copy of your own fork.
  4. Re-fork JSTips.
  5. Copy in all the changed files you saved from [1].

Going forward, you really should create a separate branch for each PR. Here's what I do:

  1. Update local fork from the main repo.
  2. Create and checkout a new branch: git checkout -b tipXX-update gh-pages
  3. Make and commit edits.
  4. Push this branch to your fork: git push upstream tipXX-update
  5. Go to your forked repo page. There should be a Compare and Pull Request button next to your new branch. Click it and follow the instructions.
SarjuHansaliya commented 8 years ago

@gromgit Oh thanks man. Now I got the problem , It makes me clear now.

So I am closing this PR. Will submit new.