search

lovesh / signature-schemes

Rust library for BLS signatures, MuSig, PS signatures
Apache License 2.0
66 stars 20 forks source link

Change EntropyRng arguments to impl Rng + CryptoRng #12

Closed JayPavlina closed 4 years ago

JayPavlina commented 4 years ago

EntropyRng is deprecated in rand 0.7. Arguments using it should be changed to impl Rng + CryptoRng.

lovesh commented 4 years ago

Fixed here https://github.com/lovesh/signature-schemes/commit/a3dc88356c031fb98f8374655ffb1a235518c2ba

JayPavlina commented 4 years ago

Is there a reason you did RngCore instead of Rng?

lovesh commented 4 years ago

Probably because i was using RngCore elsewhere as well. I see now that the Rust docs advise to use Rng. Will change.

lovesh commented 4 years ago

Changed to Rng. I don't know if it makes a difference but blindly following the Rust docs here.