search

lovesh / signature-schemes

Rust library for BLS signatures, MuSig, PS signatures
Apache License 2.0
66 stars 20 forks source link

Make AggregatedVerKey + AggregatedSignature clone #5

Closed andrewjstone closed 5 years ago

andrewjstone commented 5 years ago

Allowing cloning of signatures and keys is very useful.

andrewjstone commented 5 years ago

The CI build is failing for the same reason local builds fail. The top level workspace doesn't set a curve, but when it tries to build the amcl_rust_wrapper dependency it tries to use the setting for both bls381 and secp256k1 as defined as features in the bls and musig subcrates respectively.

Unfortunately, I'm not sure how to fix this, but it's also not caused by this change.

It should be noted that building directly in the bls crate works fine.

lovesh commented 5 years ago

Sorry for the trouble. The CI got broken after i restructured the project. Fixed it now.

andrewjstone commented 5 years ago

Thanks for fixing CI @lovesh. Can you please rerun the build and merge in the change if you agree with it?

lovesh commented 5 years ago

Thanks @andrewjstone for the contribution.