search

lovesh / signature-schemes

Rust library for BLS signatures, MuSig, PS signatures
Apache License 2.0
66 stars 20 forks source link

Update Readme link #8

Open kirk-baird opened 5 years ago

kirk-baird commented 5 years ago

Minor change to the README.md to reflect AMCL have change where the repo sits.

kirk-baird commented 5 years ago

Force pushed to add Sign-off

lovesh commented 5 years ago

The link in Readme is wrong anyway but AMCL used underneath is https://github.com/miracl/amcl and not https://github.com/apache/incubator-milagro-crypto-rust. I see that miracl/amcl is more frequently updated and maintained by M.Scott. Whats the deal with incubator-milagro-crypto-rust?

kirk-baird commented 5 years ago

So https://github.com/miracl/amcl/version3/rust simply copied the code from https://github.com/apache/incubator-milagro-crypto-rust. I was going to reach out to miracl shortly as I have started pushing some changes to the development branch of https://github.com/apache/incubator-milagro-crypto-rust, and I think it would be much more productive if we were all putting out changes together.

Let me know if you think it's a good idea to combined all the work in one place

lovesh commented 5 years ago

@kirk-baird I find the code at https://github.com/miracl/amcl/tree/master/version3/rust more recent than at apache/incubator-milagro-crypto-rust. Do you plan to keep reconciling the changes?

kirk-baird commented 5 years ago

Yep that the plan, or maybe to see if miracl would also like to push their changes upstream too so we have one consistent repo.