search

loveshdongre / leetcode-enhancer

A cross-browser extension to improve productivity on Leetcode
https://chrome.google.com/webstore/detail/leetcode-enhancer/gcmncppaaebldbkgkcbojghpmpjkdlmp
45 stars 5 forks source link

Manifest upgrade #34

Closed loveshdongre closed 8 months ago

loveshdongre commented 1 year ago

Removed few unused properties of manifest. However, earlier leetcode icon was activate on only leetcode.com and was disabled on other website is not working yet

loveshdongre commented 1 year ago

hi @natzelo Removed some unused manifest properties, however earlier icon was active on leetcode.com and disabled on other websites is not functioning yet. Would you be able to check it.

Thanks working on this issue!

natzelo commented 1 year ago

Sure! @loveshdongre

natzelo commented 1 year ago

Hi @loveshdongre , I looked into the issue and it seems to a bug in the manifest v3 itself. The stack overflow solutions seem to suggest programmatically disabling the extension on non-host websites.

https://stackoverflow.com/a/67437555 https://stackoverflow.com/a/69599087

Although they work, they however all seem to be very hacky workarounds which are not robust. How would you suggest going about this issue?

loveshdongre commented 1 year ago

@natzelo Firstly, really appreciate for putting in the hours to find the root cause of the issue 🙏

I'm more inclined towards this solution: https://stackoverflow.com/questions/69598656/prevent-popup-if-current-tab-url-is-not-permitted-in-manifest-v3/69599087#69599087 It appears more API-oriented solution and less hacky.

Thanks for the work!