lovyan03 / LovyanGFX

SPI LCD graphics library for ESP32 (ESP-IDF/ArduinoESP32) / ESP8266 (ArduinoESP8266) / SAMD51(Seeed ArduinoSAMD51)
Other
1.03k stars 189 forks source link

support file for LILYGO T-Display S3 added #405

Closed erazor83 closed 8 months ago

erazor83 commented 11 months ago

adds a file in lgfx_user for the display without touch.

Can be used like this:

#include "lgfx_user/LILYGO_T-Display-S3_ESP32-S3.hpp"
static LILYGO_TDisplay_S3 lcd;
tobozo commented 11 months ago

hi, thanks for sharing your work :+1:

It may be a good idea to also submit your configuration snippet to the vendor repository.

lovyan03 commented 11 months ago

@erazor83 Sorry for the late reply, and thanks for your PR ! Since pin_rd is set, the pixel readout function should be available. If possible, check that the readout function is working by referring to #335 .

lovyan03 commented 11 months ago

Please see the topic ahead from this comment. https://github.com/lovyan03/LovyanGFX/pull/335#issuecomment-1374469818

erazor83 commented 11 months ago

@lovyan03 Guess it works: https://github.com/erazor83/lovyan_tdsps3_readpixel

github-actions[bot] commented 10 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

lovyan03 commented 10 months ago
 cfg.readable = false;

Please change this to true and try again.

erazor83 commented 10 months ago

Done and tested.

lovyan03 commented 10 months ago

Have you confirmed that the pixel readout deforms the image into a triangle?

erazor83 commented 10 months ago

No, sorry. Is this behavior documented somewhere? The display shows the same stuff which you can see on my gif I posted earlier.

lovyan03 commented 10 months ago

image

github-actions[bot] commented 9 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 8 months ago

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.