search

lovyan03 / LovyanGFX

SPI LCD graphics library for ESP32 (ESP-IDF/ArduinoESP32) / ESP8266 (ArduinoESP8266) / SAMD51(Seeed ArduinoSAMD51)
Other
1.02k stars 187 forks source link

Fixes to Platformio env=native #521

Closed MitchBradley closed 3 months ago

MitchBradley commented 3 months ago

This patch adds Windows entries to the include and library paths in examples_for_PC/PlatformIO_SDL/platformio.ini and adds an English language version of the README.md file in that directory. README-en.md contains additional information about final setup, compilation, and running the program under VsCode/PlatformIO that is not in the original version.

tobozo commented 3 months ago

hi,

Thanks for your contribution :+1:

From the readme:

Copy files from this directory to the top level directory of this repostory

The readme should probably issue a warning about that: modifying the LovyanGFX library like this may make it unusable for other platformio environments, esp-idf, OpenCV, Arduino, etc.

Is there a way these files can stay in the platformio project folder?

MitchBradley commented 3 months ago

Is there a way these files can stay in the platformio project folder?

Yes, I already fixed that but I made a mistake in editing README-en.md to reflect the solution. https://github.com/lovyan03/LovyanGFX/pull/521/commits/d8776a3ea7d2c9d6d5e35133b18443d3bb120b7f fixes it

FYI, the M5GFX project uses LovyanGFX and I found the fix in their version - https://github.com/m5stack/M5Unified/tree/master/examples/PlatformIO_SDL

tobozo commented 3 months ago

thanks for spotting that!