search

lovyan03 / LovyanGFX

SPI LCD graphics library for ESP32 (ESP-IDF/ArduinoESP32) / ESP8266 (ArduinoESP8266) / SAMD51(Seeed ArduinoSAMD51)
Other
1.02k stars 187 forks source link

Enable stdio filesystem support #535

Closed MitchBradley closed 2 months ago

MitchBradley commented 2 months ago

It was commented out. Uncommenting it and adding a namespace qualifier to load_font_with_path made it work great. Tested with platformio native builds on Windows/Mingw32

I'm not sure why it was not enabled. My guess is that it failed to compile due to the missing Base:: on load_font_with_path(), and nobody had time to track down that problem.

MitchBradley commented 2 months ago

IDF builds are still failing. I'm trying to think of a way to enable filesystem support for native builds without making ESP-IDF choke.

MitchBradley commented 2 months ago

Okay, it passes CI now. It would be nice to say something like "#if HAS_FILE_WRAPPER" but that would require some extra work elsewhere in the code base.

If this patch is accepted, what is the best way to propagate it to M5GFX ?

tobozo commented 2 months ago

hi and thanks for your contribution :+1:

please edit your PR to use the develop branch both as base and target

MitchBradley commented 2 months ago

Closing this in favor of #536 which is based on develop