search

lovyan03 / LovyanGFX

SPI LCD graphics library for ESP32 (ESP-IDF/ArduinoESP32) / ESP8266 (ArduinoESP8266) / SAMD51(Seeed ArduinoSAMD51)
Other
1.02k stars 187 forks source link

Adding support for ILI9341_2 #550

Closed lsdlsd88 closed 1 month ago

lsdlsd88 commented 1 month ago

Alternative panel driver for some TFT screens, used for example on Sunton ESP32 boards

see

https://github.com/lovyan03/LovyanGFX/issues/546

https://github.com/Bodmer/TFT_eSPI/issues/1172

tobozo commented 1 month ago

hi and thanks for your contribution :+1:

please use the develop branch as source and target for your pull request

also have a look at how display variants are implemented, an additional file is not necessary:

https://github.com/lovyan03/LovyanGFX/blob/master/src/lgfx/v1/panel/Panel_ILI948x.hpp

lsdlsd88 commented 1 month ago

also have a look at how display variants are implemented, an additional file is not necessary:

perfect. will work on adding it that way . sorry for any noob mistakes

tobozo commented 1 month ago

you'll have to pick a name for the new base class e.g. Panel_ILI9341_Base and make sure the original Panel_ILI9341 class keeps its name in the derived form so that it does not break existing configurations, it's okay to call the new one Panel_ILI9341_2