search

lovyan03 / LovyanGFX

SPI LCD graphics library for ESP32 (ESP-IDF/ArduinoESP32) / ESP8266 (ArduinoESP8266) / SAMD51(Seeed ArduinoSAMD51)
Other
1.02k stars 187 forks source link

Adds handling for arduino_default for specifying SPI device, and not CS #560

Closed jp-bennett closed 1 week ago

jp-bennett commented 1 week ago

This is the so-simple-its-dumb approach to the SPI touchscreen issue. The idea is that we'd add SPI1 and SPI2 to portduino as extern defines, so they're always available. We can tie them to a real hardware device in our init code, and here we just use the spi_host int to specify which one to use. This is an alternative solution to #559

Edit: the addition of is_SPI is because now that we don't necessarily need a CS, there's no other way to determine for sure that it's an SPI device.

jp-bennett commented 1 week ago

And obviously it's failing here, because the pre-requisite change isn't in Portduino.

tobozo commented 1 week ago

if your PR targets a specific version of meshtastic native platform you should as well update the platformio_native.ini file to point to the relevant commit hash so that the CI job doesn't fail

jp-bennett commented 1 week ago

Closing this in favor of #561