search

lovyan03 / LovyanGFX

SPI LCD graphics library for ESP32 (ESP-IDF/ArduinoESP32) / ESP8266 (ArduinoESP8266) / SAMD51(Seeed ArduinoSAMD51)
Other
1.19k stars 210 forks source link

BUG: fillGradientRect() does not respect Y coordinate for vertical gradients #638

Closed aldoir closed 1 week ago

aldoir commented 1 week ago

https://github.com/lovyan03/LovyanGFX/blob/50a1800eb771ff8c028334d055ad37e1f12ec863/src/lgfx/v1/LGFXBase.cpp#L1128

Hello, the above line should be updated to

drawFastHLine( x, y+ys, w ); in order to properly respect the Y coordinate parameter, otherwise it always use "0" as reference. Could someone please make a PR for this?

tobozo commented 1 week ago

hi,

thanks for your feedback :+1:

this is already fixed in the develop branch and will be shipped with the upcoming release