search

lowRISC / ibex-demo-system

A demo system for Ibex including debug support and some peripherals
Apache License 2.0
53 stars 40 forks source link

Updated verilator waivers so the sim builds #91

Closed HU90m closed 8 months ago

nbdd0121 commented 8 months ago

I think the lint that you're trying to mute is a legit warning.

In ibex_register_file_fpga, if RdataMuxCheck is not enabled then the oh_raddr_a_err and oh_raddr_b_err wires are indeed not driven. Probably that should be a RTL fix instead of lint fix.

HU90m commented 8 months ago

Thanks for making these changes. I had been meaning to fix the Verilator lint file for a while. On which version of Verilator did you test this?

Verilator 4.210 (The officially supported ibex version)

HU90m commented 8 months ago

I think the lint that you're trying to mute is a legit warning.

In ibex_register_file_fpga, if RdataMuxCheck is not enabled then the oh_raddr_a_err and oh_raddr_b_err wires are indeed not driven. Probably that should be a RTL fix instead of lint fix.

I've moved the Verilator top over to using ibex_register_file_ff in https://github.com/lowRISC/ibex-demo-system/pull/93, which it should have been using anyway and with which this waiver isn't needed.

Closing this PR in favour of https://github.com/lowRISC/ibex-demo-system/pull/93