Improve shell loop syntax

lowRISC / lowrisc-toolchains

UNSUPPORTED INTERNAL toolchain builds

30 stars 14 forks source link

Improve shell loop syntax #45

Closed imphil closed 3 years ago

imphil commented 3 years ago

Error out if check-tarball.sh fails in the non-last item.
Add quoting.

mundaym commented 3 years ago

LGTM. Can you change the first line of the commit message to be 'Exit with error if check-tarball.sh fails' or something similar? The current commit summary implies to me this is just a style change.

imphil commented 3 years ago

Ha, good confirmation that I wasn't dreaming before. CI fails with tar: /__w/1/a/*.tar.xz: Cannot open: No such file or directory

asb commented 3 years ago

Of course it does...I had in my head completely the wrong mechanism for quoting rules in this case. Your previous quoting was fine (I was wrong - sorry). Though change to checking the exit condition is worth having though.

I think "${ARTIFACT_STAGING_DIR}"/*.tar.xz is what we want.