search

lowRISC / lowrisc-toolchains

UNSUPPORTED INTERNAL toolchain builds
32 stars 14 forks source link

Tidy Muntjac GCC configuration flags #47

Closed db434 closed 3 years ago

db434 commented 3 years ago

Following advice from @luismarques in #43 to avoid overwriting CFLAGS. There should be no difference in behaviour.

db434 commented 3 years ago

No, that didn't work. We're back to having luis instead of auipcs. (I also noticed that quote marks are needed around the flag, but that didn't fix things in a local build.)

Do you have any other ideas, or should we close the PR since it's already working?

luismarques commented 3 years ago

No, that didn't work. We're back to having luis instead of auipcs. (I also noticed that quote marks are needed around the flag, but that didn't fix things in a local build.)

Just to cover our bases, are you checking the toolchain libraries or just the code that the built GCC generates?

If this doesn't work then I think we can just close the PR. Thanks anyway!

db434 commented 3 years ago

I'm checking libgcc.a in the toolchain libraries. I'll close for now, but I'm happy to revisit this if there's a better solution.