search

lowRISC / manticore

Apache License 2.0
16 stars 13 forks source link

Clippy not checking tests in CI #80

Closed silvestrst closed 3 years ago

silvestrst commented 3 years ago

It seems that clippy in CI is not running over tests:

    - name: Check clippy lints
      run: cargo clippy --verbose

I think it might be useful to have an additional:

 - name: Check clippy lints
   run:` cargo clippy --tests

Unless --tests covers both cases, in which case we could just add --test to the existing run

Cypher1 commented 3 years ago

I'd recommend using

cargo clippy --all-targets

to ensure full coverage (though it does sometimes report issues twice: https://github.com/rust-lang/rust-clippy/issues/4092 )