lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.43k stars 725 forks source link

[cdc] clean-up cdc constraints #13091

Open tjaychen opened 2 years ago

tjaychen commented 2 years ago

with #13016. cdc constraints are now being introduced to the flow. These constraints are separate from sdc constraints and need their own mechanism of sourcing (right now I am temporarily including it into run-cdc.tcl, which is not right).

Further, some of the cdc constraints should be made more specific, as it is too broad from async_fifo rdata output to ibex rvalid.

msfschaffner commented 1 year ago

@tjaychen it sounds like this is mainly a cleanup item - can we potentially move this into M3?

tjaychen commented 1 year ago

yes let's move this to M3.

moidx commented 1 year ago

@cindychip does this need to be part of M2.5 or should we move it to Backlog?

msfschaffner commented 1 year ago

I don't think we have time to clean up the constraints locations for M2.5. since this is mostly cleanup, I think I am ok with postponing this.

moidx commented 3 weeks ago

Remaining CDC/RDC work is carried over to M5.

johngt commented 1 week ago

@andreaskurth - when you get back could you sync with @rswarbrick and see what remains. If it can be done in the scope of M5 then that's good - otherwise we need to consider whether this makes sense to do as a later cleanup vs putting it in the backlog.

rswarbrick commented 1 day ago

I do not know much about the tooling that the constraint files control. Removing the assignment from myself because I'm not sure I'd be much help!