search

lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.57k stars 766 forks source link

[dv/adc_ctrl] Moving assertions to RTL or interface for reusability #13540

Open cindychip opened 2 years ago

cindychip commented 2 years ago

Detailed discussion here: https://github.com/lowRISC/opentitan/issues/11744

andreaskurth commented 1 year ago

Triaged for adc_ctrl. I think this is not necessary for M2.5, so I'm labeling it https://github.com/lowRISC/opentitan/labels/Type%3AIcebox. @cindychip if you disagree, PLMK

johngt commented 4 months ago

At this stage - moving assertions to RTL is not going to be done as an ECO so should be considered for future release. @moidx / @vogelpi / @andreaskurth

matutem commented 4 months ago

Can someone clarify which assertions this refers to? There are some assertions for the adc_ctrl fsm that are written in a module at https://github.com/lowRISC/opentitan/blob/master/hw/ip/adc_ctrl/dv/sva/adc_ctrl_fsm_sva.sv, but could be moved to an interface, which is simple. Other assertions are in the tb.sv file, and I imagine these are the assertions relevant to this issue.

vogelpi commented 4 months ago

I think it's probably both the assertions inside tb.sv as well as the ones inside adc_ctrl_fsm_sva.sv. But I seriously think we have more important things to do right now. Let's not bother about this now.