lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.58k stars 777 forks source link

[otbn,dv] Parameterize `otbn_intg_err` base class #15527

Open ctopal opened 2 years ago

ctopal commented 2 years ago

When otbn_intg_err got implemented it was explicitly used for injecting integrity errors to bignum registers. Therefore the arguments for the some tasks and functions are written for BigNum lengths. If we can parameterize it, we then don't need to have otbn_rf_base_intg_err implement it's own body.

rswarbrick commented 5 months ago

I'm convinced this is a tidyup worth doing. And I think we might even be able to do it without all the parameterisation described above. But I'm removing the M4 milestone: while it's worth doing, I don't believe this is something we should delay a tapeout milestone for.