lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.5k stars 745 forks source link

[dv/lc_ctrl] Expanding JTAG registers + multiple address maps #18078

Open gdessouky opened 1 year ago

gdessouky commented 1 year ago

Description

rswarbrick commented 5 months ago

I just had a look at the TODO comments that this tracked. For the second item (in lc_ctrl_env_cfg.sv), I looked at the commit that added the TODO (517c1577431).

I think the "multiple address maps" text refers to the fact that we've cloned a UVM address map in post_build_ral_settings, giving us a second copy that represents the fact we can talk to registers over either TL or JTAG. The jtag_csr bit is supposed to be a flag that tells the DV environment to get into a mode where it uses JTAG for accesses (switching in end_of_elaboration_phase). The TODO comment is a reminder that maybe we should test this! Doing so might be as simple as randomising jtag_csr in the build phase for lc_ctrl_base_test instead of looking at a plusarg.

Probably not urgent enough for a project milestone though.

I couldn't figure out the first item, but we would probably need to spend an hour thinking before dropping it.

rswarbrick commented 2 months ago

I still believe that this is low priority (V3 at most) and probably doesn't need to be handled for M5. Tagging as a triage priority accordingly.

rswarbrick commented 2 months ago

Moving to M7, where we plan to target V3 status.

moidx commented 3 weeks ago

lc_ctrl V3 moved to next Earlgrey release.