search

lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.44k stars 730 forks source link

[pattgen] V2.5 TODOs #18389

Open rnongie opened 1 year ago

rnongie commented 1 year ago

Description

TODOs defined in pattgen Effort Scoping

D2.5 / V2.5 TODO links (1 d .. 2 d) dv/tb.sv#L51 connect test bench up and check values (1 d .. 2 d)

msfschaffner commented 1 year ago

Deprioritizing so that we can focus on more important blocks.

CC @moidx

rswarbrick commented 3 months ago

The TODO tracked above was pretty trivial (I think) and should be removed by #22582.

Annoyingly, that's not the only hit when I grep in the block! pattgen_base_vseq.sv contains:

  // TODO: consider optimize the base_vseq to make each channel
  // cfg, start, stop independently with semaphore (PR #4040)
rswarbrick commented 3 months ago

I've had a bit of a look at the PR in question and the discussion is here: https://github.com/lowRISC/opentitan/pull/4040#discussion_r517052156. The background is that @weicaiyang was pointing out that the existing DV code didn't really allow the channels to start/stop across each other. I'm not sure how important this is really, but it's probably less than a day's work to sort out so maybe worth doing.

rswarbrick commented 1 month ago

Marking as a triage priority because I believe this is really a V3 issue (removing a TODO).

rswarbrick commented 1 month ago

Since this is a V3 issue, moving to M7.