search

lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.59k stars 782 forks source link

[pwm] V2.5 TODOs #18390

Closed rnongie closed 13 hours ago

rnongie commented 1 year ago

Description

TODOs defined in PWM Effort Scoping

./dv/env/pwm_env_cov.sv:208: //regwen_cg = new(); // TODO stage V2S ./dv/cov/pwm_cov_if.sv:14: // TODO Add coverage points if needed

Estimate 0d (coverage related TODOs covered by existing issues)

msfschaffner commented 1 year ago

Deprioritizing so that we can focus on more important blocks.

CC @moidx

rswarbrick commented 5 months ago

Marking as a triage priority. I believe this is really a V3 issue and probably doesn't need to be in the M5 milestone.

rswarbrick commented 5 months ago

Moving to M7 accordingly.

rswarbrick commented 2 weeks ago

One of the TODO items listed in the issue has been removed (from pwm_env_cov.sv:208; removed by commit 24b60d571f31403af1b1725ca0954ec6417d23c3).

The remaining item is a place-holder that mentions the opportunity to add coverpoint to pwm_cov_if.sv. Honestly, we should probably do this! But it shouldn't be hard: I think we're probably exercising the block sensibly already. Estimate: 2 days.

rswarbrick commented 2 weeks ago

Oh! And it's even easier: we have functional coverage sensibly defined in pwm_env_cov.sv. The cleanup will just be removing the unneeded interface. Estimate: 1 day.