lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.5k stars 745 forks source link

[component] Verilator 4.210 generated waveform is incompatible with gtkwave 3.3.114 #18614

Open hcindyl opened 1 year ago

hcindyl commented 1 year ago

Description

The recommended verilator 4.210 in https://opentitan.org/guides/getting_started/setup_verilator.html#install-verilator is incompatible with gtkwave > 3.3.104. Note 3.3.114 is the version in debian/unstable, debian/testing, while debian/stable and ubuntu 22.04 LTS is in 3.3.104

To repo: 1) Create waveform with --test_arg=--trace in bazel test command in any of the verilator test target 2) Make sure your gtkwave is in 3.3.114 (as in glinux's apt base repo 20230505.02.03) 3) Load the sim.fst to gtkwave

Do we plan to bump the verilator version?

cfrantz commented 1 year ago

I was able to duplicate this issue with:

$ bazel test //sw/device/silicon_creator/lib/drivers:uart_functest_sim_verilator --//hw:make_options=-j --test_arg=--verilator-args=--trace --test_timeout=1000

$ gtkwave bazel-out/k8-fastbuild/bin/sw/device/silicon_creator/lib/drivers/uart_functest_sim_verilator.runfiles/lowrisc_opentitan/sim.fst

GTKWave Analyzer v3.3.114 (w)1999-2023 BSI

FACPACK | Using compressed facilities
FSTLOAD | Processing 540546 facs.
FSTLOAD | Internal error, nonsequential enum tables definition encountered, exiting.
cfrantz commented 1 year ago

Assigned to GregAC to triage, delegate and/or offer a recommendation.

a-will commented 1 year ago

Recommend updating to Verilator v4.228, the last update before major version v5.x. This appears to work fine with latest gtkwave v3.3.115, as well as v3.3.104.

hcindyl commented 1 year ago

Thanks Alex. Can someone in the OpenTitan team test and verify the version bump is good for the code?

a-will commented 1 year ago

Thanks Alex. Can someone in the OpenTitan team test and verify the version bump is good for the code?

In the past, I used it regularly myself in glinux. But for project recommendations, I'll need others to agree to change versions. :)

msfschaffner commented 11 months ago

Are we ok with bumping the verilator version?