search

lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.55k stars 759 forks source link

[alert_handler] D2(S) Signoff #20993

Closed msfschaffner closed 7 months ago

msfschaffner commented 8 months ago

Description

Ensure D2(S) signoff criteria are still maintained (this is not a focus area block).

andreaskurth commented 7 months ago

Commits since Earlgrey-ES tapeout

$ git log Earlgrey-M2.5.2-RC0..HEAD --oneline hw/top_earlgrey/ip_autogen/alert_handler

ab4b36f6b9 [ipgen,rstmgr] Fix paths to rstmgr in md files 56399241e7 Revert "[edn] Move prim_edn_req out of prim" c721c51c13 [rtl, prim] Add 'commit' functionality to prim_count 61a237e197 [util/reggen] reverse order of substruct generation 4a9a881d44 [topgen] Pass topname key/value pair to ipgen 3b4e36e01c [edn] Move prim_edn_req out of prim de31bdf1c2 [reggen] Remove the devmode input 975a6eb927 [adc_ctrl,dv] Tidy up access to intr_state in env_cfg files ca2b62b28a [dv, testplan] Replace descr by desc for consistency 3b94957561 [alert_handler,sival] Add feature list to alert_handler data 1b16ca2122 [reggen] Add mubi support SWAccess that sets/clears a reg 59f8142826 [doc] Moved badges over to using hosted images 7688e714e8 [reggen] Add initial support for version and cip_id hjson fields fbd888eea8 Revert "[reggen] Add CIP_IDs and bump all major versions" 0ba10b3cd3 [reggen] Add CIP_IDs and bump all major versions 2c6d825855 [alert_handler] Convert theory of operation to template

Issues closed since the Earlgrey-ES tapeout

https://github.com/lowRISC/opentitan/issues?q=is%3Aissue+is%3Aclosed+closed%3A%3E2023-06-27+alert_handler

None of these issues should block D2(S) signoff of this IP.

Currently open issues

https://github.com/lowRISC/opentitan/issues?q=is%3Aissue+is%3Aopen+alert_handler

None of these issues should block D2(S) signoff of this IP.

Summary

The following commits changed alert_handler's RTL (from git log --oneline Earlgrey-M2.5.2-RC0..HEAD -- hw/top_earlgrey/ip_autogen/alert_handler/rtl): 56399241e7 Revert "[edn] Move prim_edn_req out of prim" c721c51c13 [rtl, prim] Add 'commit' functionality to prim_count 61a237e197 [util/reggen] reverse order of substruct generation 3b4e36e01c [edn] Move prim_edn_req out of prim de31bdf1c2 [reggen] Remove the devmode input 1b16ca2122 [reggen] Add mubi support SWAccess that sets/clears a reg fbd888eea8 Revert "[reggen] Add CIP_IDs and bump all major versions" 0ba10b3cd3 [reggen] Add CIP_IDs and bump all major versions However, none of them changes the behavior of alert_handler. Thus, documentation and DV environment don't have to be updated.

There are currently no TODOs in alert_handler's RTL.

Checklist

alert_handler has been signed off at D3 before

:heavy_check_mark: No behavioral changes were made. :heavy_check_mark: No features were added. :heavy_check_mark: No TODOs exist in RTL code. :heavy_check_mark: The lint flow is clean. :heavy_minus_sign: There is no CDC or RDC flow at the block level. :heavy_check_mark: I have reviewed the RTL changes in the commits above. :heavy_minus_sign: There is no synthesis flow at the block level. :heavy_check_mark: No SW-visible changes were made. :heavy_check_mark: There are currently no "Won't Fix" bugs or "Errata".

Conclusion

I think alert_handler still fulfills the D2S signoff criteria. Is there a reason we don't directly sign it off at D3?

andreaskurth commented 7 months ago

@msfschaffner: Can you PTAL at this signoff analysis? TIA!

msfschaffner commented 7 months ago

Thanks for the analysis @andreaskurth.

The idea for this exercise was to double check that the IP fulfills the PROD.M2 exit criteria which is D2S/V2S.

Given that there were no changes, and that the Hjson still claims D3, I am fine with leaving it at D3: https://github.com/lowRISC/opentitan/blob/2714197f3235f1737937ad20421a3f32ff4a7030/hw/ip_templates/alert_handler/data/alert_handler.hjson.tpl#L18-L22