[edn/sw] Return the whole sts code in dif_edn_get_status

lowRISC / opentitan

OpenTitan: Open source silicon root of trust

https://www.opentitan.org

Apache License 2.0

2.44k stars 730 forks source link

[edn/sw] Return the whole sts code in dif_edn_get_status #22465

Open h-filali opened 3 months ago

h-filali commented 3 months ago

Description

Currently dif_edn_get_status sets the *set argument to 1 in case of an error and to 0 in case of success. It would be better if the set bit could be replaced by the whole sts response signal, i.e. the whole status code (which is 0 in case of success and a positive value representing the status in the error case).

vogelpi commented 3 months ago

Thanks for creating this issue @h-filali . This is not critical for the current hardware milestones. We need to check if this is relevant for ROM. I am now moving to that milestone.

moidx commented 1 month ago

Hi @vogelpi, currently the ROM only uses boot mode entropy. Should we move this to the ROM_EXT? That is the first time we do a full entropy complex configuration in continuous mode. If you agree, please move to the ROM_EXT milestone. Thanks!

vogelpi commented 1 month ago

Yes, that sounds fair to me @moidx . In ROM, the whole entropy complex runs in hardware defined mode. Software cannot operate it in the wrong way, so there is no strict need to infer status flags.