andreaskurth
commented
2 months ago Analysis of changes since previous signoff
sensor_ctrl got previously signed off at D3 in 9f31bc3b2ea59614655532e00294248f7bbbb04a and that wasn't changed when the version was increased to 2.0.0 in d352f0cf45299ed1a9715ca72fce052be21cb00b. So formally, sensor_ctrl is currently still signed off at D3. For completeness' sake, however, here are the changes since the previous D3 signoff (git log --pretty=oneline 9f31bc3b2ea59614655532e00294248f7bbbb04a..bff93a06f5e569270c56ec08db723722de9da805 hw/top_earlgrey/ip/sensor_ctrl/rtl | tac, thus old to new):
- e063764dd06f0c61dad3f992cee794d13679c716 [tlul] Add access latency and ifetch to adapter_reg --> no functional change
- 0ba10b3cd3157d233c6a9a21676b058971399b99 [reggen] Add CIP_IDs and bump all major versions --> reverted by commit below
- fbd888eea85260f03095b7b7f12537638ca27183 Revert "[reggen] Add CIP_IDs and bump all major versions" --> reverts commit above
- 1b16ca2122d956f4b1f909ba2e996b01ff22001e [reggen] Add mubi support SWAccess that sets/clears a reg --> no functional change
- de31bdf1c26be2714ca787c6041a56eb56eb7d1e [reggen] Remove the devmode input --> no functional change
- eef87110bb60997becccdf1cec4ed736ea673b99 [rtl,sensor_ctrl] Fix CDC bug --> fixes CDC bug #20614
- 61a237e1973d6a29d377c2be871139553c7d344f [util/reggen] reverse order of substruct generation --> does not change behavior
- d352f0cf45299ed1a9715ca72fce052be21cb00b [sensor_ctrl] Add enable register for AST alerts --> functional change to add an enable register for AST alerts; LGTM
- 30d7e787c753caaa03fe68a4a70da1bbcbc1d96f Add the project name to the copyright header --> no functional change
- 8b15c287f8b8e5618681b4d9d1a28ea7d400ed72 [top_earlgrey,sensor_ctrl] Add input disable attribute for manual pads --> adds functionality (and CSRs) to disable the input driver of manual pads; LGTM
- 4c15bdc9fa0d882c5d53068d9d86658c2a48ee07 [sensor_ctrl] Change reset value of
ALERT_ENCSRs to MuBiTrue --> changes all alerts to be enabled at reset; part of #23149; LGTM - 39157f7a7ac94e42f05cde9daa8ae8cde9d900e1 [top_earlgrey,sensor_ctrl] Add pull attributes for manual pads --> adds functionality (and CSR fields) to control pull-up/down of manual pads; LGTM
Thus the functional changes since the previous D3 signoff LGTM.
D3 Signoff Checklist
- :white_check_mark: NEW_FEATURES_D3:
- Documentation: New features have been documented.
- DV: sensor_ctrl has no block-level DV, but the new features are covered by top-level tests.
- SW: Not all features have been implemented in the DIF yet (see #23145), but the features are sufficiently simple that this shouldn't be a problem.
- :white_check_mark: TODO_COMPLETE: There are no
TODOs in sensor_ctrl's RTL code. - ✅ LINT_COMPLETE: sensor_ctrl's RTL is clean in AscentLint. The lint waiver has not been changed since the previous D3 signoff, hence it doesn't have to be approved by TC again.
- :wavy_dash: CDC_COMPLETE: Waived because there's no CDC flow at the block level.
- :wavy_dash: RDC_COMPLETE: Waived because there's no RDC flow at the block level.
- :white_check_mark: REVIEW_RTL: Reviewed changes since the previous D3 signoff, during which the entire RTL was reviewed, in detail
- :wavy_dash: REVIEW_DELETED_FF: Waived because there's no synthesis at the block level.
- ✅ REVIEW_SW_CHANGE: Reviewed by OT SW team on 2024-08-07; confirmed in #software on Slack.
- :white_check_mark: REVIEW_SW_ERRATA: There are no "Won't fix" bugs or "Errata" known for sensor_ctrl.
vogelpi
Description
No response