lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.43k stars 726 forks source link

[hmac, TLT] Extend multistream top-level test for HMAC #23507

Closed ballifatih closed 1 day ago

ballifatih commented 3 weeks ago

Description

Spin-off from https://github.com/lowRISC/opentitan/pull/23494#pullrequestreview-2099019551, https://github.com/lowRISC/opentitan/pull/23494#discussion_r1626138082 and https://github.com/lowRISC/opentitan/pull/23471#issuecomment-2146104610

Current HMAC multistream TLT is about HMAC/SHA-2 streams that perform context switches in interleaving fashion. We would like to improve this test in order to have a better coverage:

Related to #22332

vogelpi commented 2 days ago

@ballifatih, based on the description of PR #23780, I think all the points raised above have been taken care of and we can close this issue. Do you agree? If not, can you please clarify what's missing? Thanks!

ballifatih commented 1 day ago

I only wanted to see few runs of the TLT before closing this. I just had a quick look at the last three runs of chip_sw_hmac_multistream and they were all passing. I am closing this issue.