[hmac,dv] Avoid reseeding for HMAC test vectors tests

lowRISC / opentitan

OpenTitan: Open source silicon root of trust

https://www.opentitan.org

Apache License 2.0

2.59k stars 779 forks source link

[hmac,dv] Avoid reseeding for HMAC test vectors tests #23980

Open gdessouky opened 4 months ago

gdessouky commented 4 months ago

Looking into the HMAC/SHA-2 test vector tests, I don't see the gains from reseeding. We feed all the test vectors anyway with every iteration, just in a different order. No other randomization is happening, so am not sure what do we gain from reseeding 5 times, unless I am missing something.

@martin-velay @rswarbrick

Originally posted by @gdessouky in https://github.com/lowRISC/opentitan/issues/23978#issuecomment-2219947032

martin-velay commented 3 months ago

See this issue https://github.com/lowRISC/opentitan/issues/24303, as the way done for KMAC seems to be a good option to avoid too long tests

martin-velay commented 3 months ago

Could be moved to M7 backlog as this won't give us more confidence