lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.5k stars 745 forks source link

[rv_dm] rv_dm needs a UNR report #24146

Closed rswarbrick closed 1 week ago

rswarbrick commented 1 month ago

Description

Looking at results from the nightlies, the FSM coverage is low. But it turns out that the missing coverage is not possible! The two main areas are:

In both cases, I'd expect UNR to mark the states as unreachable.

There are two edges which I believe are possible (state_q going from Read or Write to Idle). I think this happens if we get a trst_n reset on the JTAG bus when the FSM is in the Read or Write state. That remains to be addressed, but won't be affected by a UNR report.

Note that the FSM coverage is currently reported as 75%, which is below the threshold needed for V2. Assuming my diagnosis is correct, the UNR report will jump the number well over the threshold.

rswarbrick commented 1 month ago

The two edges mentioned at the end of the initial report are possible to hit (I'm pleased to say). PR #24152 hits them.

rswarbrick commented 1 week ago

This was done by @moidx in 51852781d790a158784169effa7b785ba689612f.