lowRISC / opentitan

OpenTitan: Open source silicon root of trust
https://www.opentitan.org
Apache License 2.0
2.59k stars 780 forks source link

[fpv,pinmux] Can we keep a single fpv pinmux_tb #24843

Open matutem opened 1 month ago

matutem commented 1 month ago

Description

The fpv flow for pinmux has two testbench tops

They differ in various mio and dio attributes, mostly pad_type and scan_role. The one under top_earlgrey assigns these attributes per pin, while the one under hw/ip makes a blanket assignment to all mio and dios.

I will preserve this dichotomy when transitioning pinmux to ipgen, placing both tb's each with a separate core file under ip_templates, so ip_autogen will keep them. However, I wonder why we need to have both at all. There are a few contributors to these files, most significantly @cindychip and @msfschaffner, and their feedback would be valuable. However, both have transitioned to other principal projects.

matutem commented 4 weeks ago

Apparently no hjson file invokes the fpv under hw/ip/pinmux. Seems like it can be removed. In the ipgen files we have two fpv core files, so I can remove one of them. WDYT?