lowcoder-org / lowcoder

🔥 🔥 🔥 The Open Source Retool, Tooljet and Appsmith Alternative
https://www.lowcoder.cloud/
GNU Affero General Public License v3.0
913 stars 187 forks source link

[Bug]: Inline table edits do not persist if original value is null #1299

Open lanedsmu opened 2 days ago

lanedsmu commented 2 days ago

Is there an existing issue for this?

Current Behavior

When editing a value in a table, the editing works as expected if there is a value already in that cell. If, however, the original value is null, that field reverts to null after typing a value in it. There isn't any value to save, therefore.

Expected Behavior

Edited fields should allow changing from null->value just as when changing an existing value

Steps to reproduce

create a table, with some cells having null values. Mark those as editable. When editing those null values, the new value doesn't "stick"

Environment

self-hosted docker multi v2.4.12

Additional Information

No response

jnewman-eti commented 1 day ago

Also related to data having null values: as of 2.4.12, some tables in our apps have stopped selecting rows if data backing the table is null. This is a difficult issue to reproduce, because when the data is static the table works fine.

This is the console error that is produced when this happens. No rows except the first row are able to be selected.

If we remap the interpolated variable that holds the data by making sure null values are converted to empty string, then this issue goes away. This is not a feasible solution to this problem, and needs to be picked up.
7065686.txt