lowe-lab-ucl / arboretum

Track and lineage visualization with btrack and Napari :evergreen_tree:
MIT License
43 stars 11 forks source link

Add linting and run ruff #84

Closed paddyroddy closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 :warning:

Comparison is base (38c1be7) 96.72% compared to head (a163dc3) 96.69%.

:exclamation: Current head a163dc3 differs from pull request most recent head 4905840. Consider uploading reports for the commit 4905840 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #84 +/- ## ========================================== - Coverage 96.72% 96.69% -0.03% ========================================== Files 16 14 -2 Lines 580 575 -5 ========================================== - Hits 561 556 -5 Misses 19 19 ``` | [Impacted Files](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [napari\_arboretum/\_tests/test\_dock\_widget.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9fdGVzdHMvdGVzdF9kb2NrX3dpZGdldC5weQ==) | `100.00% <ø> (ø)` | | | [napari\_arboretum/\_\_init\_\_.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9fX2luaXRfXy5weQ==) | `50.00% <100.00%> (-21.43%)` | :arrow_down: | | [napari\_arboretum/\_hookimpls.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9faG9va2ltcGxzLnB5) | `66.66% <100.00%> (ø)` | | | [napari\_arboretum/\_tests/test\_graph.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9fdGVzdHMvdGVzdF9ncmFwaC5weQ==) | `100.00% <100.00%> (ø)` | | | [napari\_arboretum/\_tests/test\_plugin.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9fdGVzdHMvdGVzdF9wbHVnaW4ucHk=) | `100.00% <100.00%> (ø)` | | | [napari\_arboretum/\_tests/test\_sample\_data.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9fdGVzdHMvdGVzdF9zYW1wbGVfZGF0YS5weQ==) | `100.00% <100.00%> (ø)` | | | [napari\_arboretum/graph.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9ncmFwaC5weQ==) | `100.00% <100.00%> (ø)` | | | [napari\_arboretum/plugin.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9wbHVnaW4ucHk=) | `89.55% <100.00%> (+0.48%)` | :arrow_up: | | [napari\_arboretum/sample/sample\_data.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS9zYW1wbGUvc2FtcGxlX2RhdGEucHk=) | `100.00% <100.00%> (ø)` | | | [napari\_arboretum/tree.py](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmFwYXJpX2FyYm9yZXR1bS90cmVlLnB5) | `100.00% <100.00%> (ø)` | | | ... and [4 more](https://codecov.io/gh/lowe-lab-ucl/arboretum/pull/84?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

p-j-smith commented 1 year ago

Tests are passing!

It looks like linting if failing because there is no token in secrets for access to sourcery, although I can't check because I'm not an admin.

And the napari hub preview page is complaining about ModuleNotFoundError: No module named 'npe2' - does this need to be installed in the workflow?

paddyroddy commented 1 year ago

Tests are passing!

It looks like linting if failing because there is no token in secrets for access to sourcery, although I can't check because I'm not an admin.

And the napari hub preview page is complaining about ModuleNotFoundError: No module named 'npe2' - does this need to be installed in the workflow?

Didn't mean to add sourcery, have removed. Will look into the npe2 bit.

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/lowe-lab-ucl/arboretum/84 Updated: 2023-03-06T13:57:11.934434

paddyroddy commented 1 year ago

Plugin preview working, changing the version to @v0.1