lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
21 stars 12 forks source link

Corrected how resource governor classifier name is being assigned to … #117

Closed kodurisudhir closed 2 years ago

kodurisudhir commented 2 years ago

Description

Corrected how resource governor classifier name is being assigned to the variable.

It throws an error when trying to assign NULL value to the classifier function name. The classifier name can be retrieved from $rg.ClassifierFunction.

How Has This Been Tested?

Yes, it was tested locally.

Types of changes

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #117 (e7fc0bf) into main (d2e5417) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   94.00%   94.05%   +0.04%     
==========================================
  Files          59       59              
  Lines        2002     2002              
  Branches        2        2              
==========================================
+ Hits         1882     1883       +1     
+ Misses        120      119       -1     
Impacted Files Coverage Δ
plugins/modules/resource_governor.ps1 94.44% <100.00%> (+2.77%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lowlydba commented 2 years ago

Thanks @kodurisudhir ! Can you also add a changelog fragment describing the change, like here.