lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
21 stars 12 forks source link

Feature/sql mi fix #145

Closed jkrilov closed 1 year ago

jkrilov commented 1 year ago

Description

Remove the default option for reuse_source_folder_structure to allow for compatibility with Azure SQL MI

How Has This Been Tested?

Not tested

Types of changes

Checklist:

jkrilov commented 1 year ago

Found another parameter that isn't allowed by Azure SQL MI.

github-actions[bot] commented 1 year ago

Docs Build 📝

Thank you for contribution!✨

The docs for this PR have been published here: https://lowlydba.github.io/lowlydba.sqlserver/pr/145

You can compare to the docs for the main branch here: https://lowlydba.github.io/lowlydba.sqlserver/branch/main

The docsite for this PR is also available for download as an artifact from this run: https://github.com/lowlydba/lowlydba.sqlserver/actions/runs/3615873270

File changes:

Click to see the diff comparison. **NOTE:** only file modifications are shown here. New and deleted files are excluded. See the file list and check the published docs to see those files. ```diff diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/restore_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/restore_module.html index a47eff2..121736e 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/restore_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/restore_module.html @@ -389,7 +389,7 @@ see reuse_source_folder_structure.

Choices:

    -
  • false ← (default)

  • +
  • false

  • true

```
codecov-commenter commented 1 year ago

Codecov Report

Base: 94.00% // Head: 93.96% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (d7f5e5f) compared to base (4b5f7e0). Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #145 +/- ## ========================================== - Coverage 94.00% 93.96% -0.05% ========================================== Files 62 62 Lines 2103 2104 +1 ========================================== Hits 1977 1977 - Misses 126 127 +1 ``` | [Impacted Files](https://codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | Coverage Δ | | |---|---|---| | [plugins/modules/restore.py](https://codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/145/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#diff-cGx1Z2lucy9tb2R1bGVzL3Jlc3RvcmUucHk=) | `100.00% <ø> (ø)` | | | [plugins/modules/restore.ps1](https://codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/145/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#diff-cGx1Z2lucy9tb2R1bGVzL3Jlc3RvcmUucHMx) | `90.40% <66.66%> (-0.73%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lowlydba commented 1 year ago

Could you add a changelog fragment file as well? Thank you!

jkrilov commented 1 year ago

I knew I missed something, added the change log.