[Bug] Login always reports changed

[jkrilov]

Describe the bug lowlydba.sqlserver.login always shows as changed

To Reproduce

Redacted code snipped:

- name: Create login
  lowlydba.sqlserver.login:
    sql_instance: "{{ SQL_HOSTNAME }}"
    sql_username: "{{ SQL_ADMIN_USER }}"
    sql_password: "{{ SQL_ADMIN_PASS }}"
    login: "{{ SQL_USER }}"
    password: "{{ SQL_PASS }}"
    password_expiration_enabled: false
    password_policy_enforced: false
    language: "us_english"

Expected behavior Login should only change when first created.

Versions(please complete the following information):

• OS: Windows 2019
• SQL Server: Azure SQL MI
• PowerShell: 7.3.1

Additional context

[lowlydba]

Thanks for the issue! I think its a matter of not handling the default NULL properties properly when comparing to existing values, should be an easy fix.

[lowlydba]

Ok, so after taking a look I think the issue is probably from supplying a Password. Since we can't fetch the existing password, we can't really know if the one being supplied is different, so every time it is supplied it gets set for the Login and the result is always changed in that case.

Even if the password is set the same, properties like PasswordLastSetTime are updated.

I can definitely add a callout about this in the documentation, but don't have any other ideas how to make it more accurate. Open to suggestions if you have any.

[lowlydba]

I closed this with the aforementioned docs update, but if you have any other ideas feel free to comment here or open a new issue!