Closed jkrilov closed 1 year ago
Patch coverage has no change and project coverage change: -4.26%
:warning:
Comparison is base (
9a5a958
) 93.80% compared to head (dc9495a
) 89.55%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm game to add this as an additional integration test, but want to keep the download option in the tests for sure to get proper end-to-end coverage since that is likely how most people will be using it.
I don't see any issues reported in dbatools about this, or incidents for Github.com so am going to guess it may be transient and will resolve itself soon. It hasn't been a problem before.
Fair enough. I'll revert the changes, and add the local file as an additional test.
Fair enough. I'll revert the changes, and add the local file as an additional test.
Thanks! I also opened a Github support issue to see if this can get resolved faster that way.
This hasn't been a problem for a while, so perhaps how the VMs are allocated, or API throttling has been changed on GitHub's side. I'm going to close for now but feel free to re-open and continue work if it becomes an issue again.
Description
Use a local file to install sp_whoisactive during integration tests to avoid 403 error
How Has This Been Tested?
Types of changes
Checklist:
version_added
property.