SQL Logins for always on instances require that the SID match across all nodes in the cluster. DBAtools already supports the sid parameter so just adding it as an optional parameter.
Fixes lowlydba/lowlydba.sqlserver#189
How Has This Been Tested?
Add sid to the integration test for login.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue) - Fixes #
[x] New feature (non-breaking change which adds functionality)
Checklist:
[x] I have read/followed the CONTRIBUTING document.
Thanks for the enhancement @OsirisDBA! I've fixed the broken tests on main, could you update your fork? If the workflows come back green I'm happy to merge.
Description
SQL Logins for always on instances require that the SID match across all nodes in the cluster. DBAtools already supports the sid parameter so just adding it as an optional parameter.
Fixes lowlydba/lowlydba.sqlserver#189
How Has This Been Tested?
Add sid to the integration test for login.
Types of changes
Checklist:
version_added
property.