lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
20 stars 12 forks source link

ci: fix remote ansible script + insecure win connections #193

Closed lowlydba closed 1 year ago

lowlydba commented 1 year ago

Fix moved Ansible config script + breakage where insecure connection defaults stopped sticking

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -6.20% :warning:

Comparison is base (fe74b2e) 100.00% compared to head (aa58e7e) 93.80%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #193 +/- ## =========================================== - Coverage 100.00% 93.80% -6.20% =========================================== Files 33 64 +31 Lines 106 2196 +2090 =========================================== + Hits 106 2060 +1954 - Misses 0 136 +136 ``` | Flag | Coverage Δ | | |---|---|---| | sanity | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#carryforward-flags-in-the-pull-request-comment) to find out more. [see 31 files with indirect coverage changes](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/193/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lowlydba commented 1 year ago

Most of the issues fixed, except a seemingly new one where turning off encryption and turning trust on in the setup doesn't translate to the module tests anymore. Worst case, we can set an 'insecure' option for each module and use it for testing. But I'd like to think if there's a simpler way to achieve it globally like it was working previously. Not sure why it stopped working.