lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
20 stars 12 forks source link

Feature/issue 189 add sid to login #194

Closed OsirisDBA closed 1 year ago

OsirisDBA commented 1 year ago

Description

SQL Logins for always on instances require that the SID match across all nodes in the cluster. DBAtools already supports the sid parameter so just adding it as an optional parameter.

Fixes lowlydba/lowlydba.sqlserver#189

How Has This Been Tested?

Add sid to the integration test for login.

Types of changes

Checklist:

github-actions[bot] commented 1 year ago

Docs Build πŸ“

Thank you for contribution!✨

The docs for this PR have been published here: https://lowlydba.github.io/lowlydba.sqlserver/pr/194

You can compare to the docs for the main branch here: https://lowlydba.github.io/lowlydba.sqlserver/branch/main

The docsite for this PR is also available for download as an artifact from this run: https://github.com/lowlydba/lowlydba.sqlserver/actions/runs/5786959294

File changes:

Click to see the diff comparison. **NOTE:** only file modifications are shown here. New and deleted files are excluded. See the file list and check the published docs to see those files. ```diff diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/ag_listener_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/ag_listener_module.html index fada97f..ca5b234 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/ag_listener_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/ag_listener_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.ag_listener module – Configures an availability group listener

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/ag_replica_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/ag_replica_module.html index e9fff8c..e5ba098 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/ag_replica_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/ag_replica_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.ag_replica module – Configures an availability group replica

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/agent_job_category_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/agent_job_category_module.html index df728a0..34c846b 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/agent_job_category_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/agent_job_category_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.agent_job_category module – Configures a SQL Agent job category

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/agent_job_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/agent_job_module.html index 1b06020..fd72907 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/agent_job_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/agent_job_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.agent_job module – Configures a SQL Agent job

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/agent_job_schedule_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/agent_job_schedule_module.html index 14cc5bc..b284fa7 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/agent_job_schedule_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/agent_job_schedule_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.agent_job_schedule module – Configures a SQL Agent job schedule

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/agent_job_step_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/agent_job_step_module.html index 2ec7368..b3745ec 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/agent_job_step_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/agent_job_step_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.agent_job_step module – Configures a SQL Agent job step

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/availability_group_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/availability_group_module.html index 198db3c..c6f88d1 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/availability_group_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/availability_group_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.availability_group module – Configures availability group(s)

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/backup_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/backup_module.html index 0c614f2..5d53c98 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/backup_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/backup_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.backup module – Performs a backup operation

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/credential_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/credential_module.html index d9ac111..e8f104b 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/credential_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/credential_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.credential module – Configures a credential on a SQL server

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/database_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/database_module.html index 58f8a19..11709ee 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/database_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/database_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.database module – Creates and configures a database

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/dba_multitool_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/dba_multitool_module.html index 1d534c4..302fe49 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/dba_multitool_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/dba_multitool_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.dba_multitool module – Install/update the DBA Multitool suite by John McCall

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/first_responder_kit_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/first_responder_kit_module.html index 05c95f2..b2c63db 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/first_responder_kit_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/first_responder_kit_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.first_responder_kit module – Install/update the First Responder Kit scripts

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/hadr_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/hadr_module.html index 3c891ac..e1514cf 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/hadr_module.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/hadr_module.html @@ -130,7 +130,7 @@

lowlydba.sqlserver.hadr module – Enable or disable HADR

Note

-

This module is part of the lowlydba.sqlserver collection (version 2.0.0).

+

This module is part of the lowlydba.sqlserver collection (version 2.1.0).

To install it, use: ansible-galaxy collection install lowlydba.sqlserver. You need further requirements to be able to use this module, see Requirements for details.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/index.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/index.html index fd8af97..6b06f3c 100644 --- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/index.html +++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/index.html @@ -127,7 +127,7 @@

Lowlydba.Sqlserver

-

Collection version 2.0.0

+

Collection version 2.1.0

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +6.20% :tada:

Comparison is base (84756bc) 93.79% compared to head (a93015e) 100.00%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #194 +/- ## =========================================== + Coverage 93.79% 100.00% +6.20% =========================================== Files 64 33 -31 Lines 2192 106 -2086 =========================================== - Hits 2056 106 -1950 + Misses 136 0 -136 ``` | Flag | Coverage Ξ” | | |---|---|---| | sanity | `100.00% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | Coverage Ξ” | | |---|---|---| | [plugins/modules/login.py](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#diff-cGx1Z2lucy9tb2R1bGVzL2xvZ2luLnB5) | `100.00% <ΓΈ> (ΓΈ)` | | | [plugins/modules/sa.py](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#diff-cGx1Z2lucy9tb2R1bGVzL3NhLnB5) | `100.00% <ΓΈ> (ΓΈ)` | | ... and [31 files with indirect coverage changes](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/194/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OsirisDBA commented 1 year ago

@lowlydba These windows ones are still failing on .github/workflows/ansible-test-windows.yml

lowlydba commented 1 year ago

@lowlydba These windows ones are still failing on .github/workflows/ansible-test-windows.yml

Yeah, I am working on some of the Windows encryption issues in another PR - this is a pretty straightforward change so I'm OK with just the linux CI passing.

I'll get this released once the Windows issues are cleared up. Thanks again!