lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
19 stars 12 forks source link

Fixes #198, adds param to support removing inaccessible databases #199

Closed git-cgallagher closed 1 year ago

git-cgallagher commented 1 year ago

Description

Adds _onlyaccessible parameter to module to support removing orphaned database on availability group replica.

How Has This Been Tested?

Local testing

Types of changes

Checklist:

github-actions[bot] commented 1 year ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://lowlydba.github.io/lowlydba.sqlserver/branch/main

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9a5a958) 93.80% compared to head (c616ff6) 93.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #199 +/- ## ======================================= Coverage 93.80% 93.81% ======================================= Files 64 64 Lines 2196 2198 +2 ======================================= + Hits 2060 2062 +2 Misses 136 136 ``` | [Flag](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/199/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/199/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | Coverage Δ | | |---|---|---| | [plugins/modules/database.py](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#diff-cGx1Z2lucy9tb2R1bGVzL2RhdGFiYXNlLnB5) | `100.00% <ø> (ø)` | | | [plugins/modules/database.ps1](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/199?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#diff-cGx1Z2lucy9tb2R1bGVzL2RhdGFiYXNlLnBzMQ==) | `85.10% <100.00%> (+0.21%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lowlydba commented 1 year ago

Thank you for the contribution! Looks great.