lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
19 stars 12 forks source link

Fixes#200 no exception error handling during absent state #203

Closed git-cgallagher closed 1 year ago

git-cgallagher commented 1 year ago

Description

Adds conditional handling of result of Remove-DbaDatabase

Errors are not thrown for all failure scenarios

How Has This Been Tested?

Yes, locally

Types of changes

Checklist:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +6.18% :tada:

Comparison is base (104572c) 93.81% compared to head (1c7a336) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #203 +/- ## =========================================== + Coverage 93.81% 100.00% +6.18% =========================================== Files 64 33 -31 Lines 2198 106 -2092 =========================================== - Hits 2062 106 -1956 + Misses 136 0 -136 ``` | [Flag](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/203/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/203/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#carryforward-flags-in-the-pull-request-comment) to find out more. [see 31 files with indirect coverage changes](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/203/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

git-cgallagher commented 1 year ago

@lowlydba not sure what to make of that failure on codecov/patch

lowlydba commented 1 year ago

@lowlydba not sure what to make of that failure on codecov/patch

Its not a big deal, this one isn't worth setting up unit tests for due to the complexity.