lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
19 stars 12 forks source link

fix: refer to portnumber property correctly #209

Closed lowlydba closed 10 months ago

lowlydba commented 10 months ago

Description

Make sure we're comparing a property that is actually returned from the listener getter

How Has This Been Tested?

We don't have AG tests due to the complexity at this time.

Types of changes

Checklist:

codecov-commenter commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (787f403) 93.68% compared to head (71631d4) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #209 +/- ## =========================================== + Coverage 93.68% 100.00% +6.31% =========================================== Files 64 33 -31 Lines 2202 106 -2096 =========================================== - Hits 2063 106 -1957 + Misses 139 0 -139 ``` | [Flag](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/209/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/209/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#carryforward-flags-in-the-pull-request-comment) to find out more. [see 31 files with indirect coverage changes](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/209/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://lowlydba.github.io/lowlydba.sqlserver/branch/main