lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
19 stars 12 forks source link

Issue-214: Add ActiveStartDate to compare property #215

Closed OsirisDBA closed 6 months ago

OsirisDBA commented 9 months ago

Add ActiveStartDate to the compare properties so this item is marked accurately as changed.

lowlydba commented 9 months ago

Errors are rate limiting related, nothing to do with this PR.

Looks good to me, thanks a lot for the fix! Can you also add a changelog fragment like on your previous PR?

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cf0e221) 93.68% compared to head (b76e52e) 89.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #215 +/- ## ========================================== - Coverage 93.68% 89.38% -4.31% ========================================== Files 64 52 -12 Lines 2202 1451 -751 ========================================== - Hits 2063 1297 -766 - Misses 139 154 +15 ``` | [Flag](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/215/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/215/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.