lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
19 stars 12 forks source link

fixes #218 #219

Closed mfann-or closed 6 months ago

mfann-or commented 7 months ago

Description

Updated the backslash to a forward-slash for the $spn var

Fixes the same error outlined here

How Has This Been Tested?

Tested on local environment with AD

Types of changes

Checklist:

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cf0e221) 93.68% compared to head (53eea99) 93.68%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #219 +/- ## ======================================= Coverage 93.68% 93.68% ======================================= Files 64 64 Lines 2202 2202 ======================================= Hits 2063 2063 Misses 139 139 ``` | [Flag](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/219/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/lowlydba/lowlydba.sqlserver/pull/219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+McCall#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lowlydba commented 6 months ago

Thanks for the bug fix! It looks good. Can you just add a change fragment (example) so this change gets logged in the changelog?