Closed daarrn closed 2 months ago
Hello, very first time attempting to contribute, please don't be shy to let me know if I missed performing something correctly in the contribution process. Thanks for your work!
I think you will need to update the type of the subnet_mask too.
I think you will need to update the type of the subnet_mask too.
I think you are right that the change will be needed there as well. I do not have a use case to test that change and left it out of my request due to that
Hi @daarrn ! Thank you for the pull request. I'll try to take a look at it this weekend and provide feedback.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.69%. Comparing base (
de0aac7
) to head (ead4087
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@daarrn I tested this on a couple of VMs on my laptop on two different subnets with different subnet masks, and I can confirm you would have to change the subnet mask parameter to a list too.
The sanity checks are still failing due to the list changes not being updated in the
ag_listener.py
documentation file.
whoops, yup. Updated document file, thank you!
Thank you for contribution!✨
This PR has been merged and the docs are now incorporated into main
:
https://lowlydba.github.io/lowlydba.sqlserver/branch/main
Looks great! Thanks again for the enhancement, this is a very nice upgrade.
Description
changing spec options, ip_address parameter is being changed from a 'str' type to a 'list' type
fixes issue #245
How Has This Been Tested?
validated the change using a local collection of lowlydba and was able to successfully create a multi subnet ag listener when the ip_address parameter was expecting a list
Types of changes
Checklist:
version_added
property.