lowlydba / lowlydba.sqlserver

:spoon: A cross-platform Ansible collection using PowerShell to configure and maintain SQL Server.
https://galaxy.ansible.com/ui/repo/published/lowlydba/sqlserver
GNU General Public License v3.0
19 stars 12 forks source link

[Request] logins configure roles too #250

Open DorBreger opened 1 month ago

DorBreger commented 1 month ago

Is your feature request related to a problem? Please describe. when using the login module I would like to add roles too. Describe the solution you'd like A clear and concise description of what you want to happen. Have another parameter of type list with all roles that will be granted to the login Describe alternatives you've considered

Additional context

lowlydba commented 1 month ago

Are you thinking server roles or database roles?

DorBreger commented 1 month ago

Server

lowlydba commented 1 month ago

That seems like a good fit! It may make sense to also add a module for defining server roles as well to complement this (#251)

lowlydba commented 1 month ago

So my schedule is going to be crazy for a while, and I thought I'd have time to work on this but likely will not. I did start getting the initial logic down, if you want to use it as a head start on making a PR.

https://github.com/lowlydba/lowlydba.sqlserver/compare/add-roles-to-login?expand=1

DorBreger commented 1 month ago

So my schedule is going to be crazy for a while, and I thought I'd have time to work on this but likely will not. I did start getting the initial logic down, if you want to use it as a head start on making a PR.

https://github.com/lowlydba/lowlydba.sqlserver/compare/add-roles-to-login?expand=1

Sure. I'm quite busy as well, but I will try to tackle this when I have time, it seems interesting, thanks for the help!

DorBreger commented 1 month ago

seems like I need to be a collaborator for this link to work

lowlydba commented 1 month ago

Ah, sorry about that. Does this work? https://github.com/lowlydba/lowlydba.sqlserver/compare/main...add-roles-to-login